[SYCL] Extract sycl-post-link utilities to SYCLPostLink library#21678
Open
maksimsab wants to merge 2 commits intointel:syclfrom
Open
[SYCL] Extract sycl-post-link utilities to SYCLPostLink library#21678maksimsab wants to merge 2 commits intointel:syclfrom
maksimsab wants to merge 2 commits intointel:syclfrom
Conversation
Move file I/O and module processing utilities from sycl-post-link tool to new Utils.h/cpp. Extracts saveModuleIR, saveModuleProperties, saveModuleSymbolTable, and isTargetCompatibleWithModule functions. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
mdtoguchi
approved these changes
Apr 2, 2026
llvm/lib/SYCLPostLink/Utils.cpp
Outdated
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
| // See comments in the header. |
Contributor
There was a problem hiding this comment.
Why not just duplicate the string that is in the header.
Suggested change
| // See comments in the header. | |
| // Low-level utility functions for SYCL post-link processing. |
Contributor
Author
There was a problem hiding this comment.
LLVM Coding standards specifically says not to do that:
Don’t duplicate the documentation comment in the header file and in the implementation file
https://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments
However, both approaches are met in the codebase. I don't object of duplicating this comment.
Contributor
Author
|
@intel/llvm-gatekeepers Could we please merge that? |
Contributor
|
@maksimsab This PR needs conflicts resolved after merging the other one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move file I/O and module processing utilities from sycl-post-link tool to new Utils.h/cpp. Extracts saveModuleIR, saveModuleProperties, saveModuleSymbolTable, and isTargetCompatibleWithModule functions.